Fixes a few AATH failures #1897
Conversation
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1897 +/- ##
==========================================
- Coverage 93.79% 93.76% -0.04%
==========================================
Files 539 539
Lines 34084 34105 +21
==========================================
+ Hits 31970 31978 +8
- Misses 2114 2127 +13 |
|
Helpful to know which ones are fixed :-). I'll check it out on main and this branch. |
Signed-off-by: Ian Costanzo <[email protected]>
| @@ -424,7 +424,8 @@ async def revoke(request: web.BaseRequest): | |||
| body["notify"] = body.get("notify", context.settings.get("revocation.notify")) | |||
| notify = body.get("notify") | |||
| connection_id = body.get("connection_id") | |||
| notify_version = body.get("notify_version", "v1_0") | |||
| body["notify_version"] = body.get("notify_version", "v1_0") | |||
| notify_version = body["notify_version"] | |||
There was a problem hiding this comment.
Question about this change - basically it changes aca-py behaviour to always send a revocation notification if the startup option is set (--notify-revocation) vs only sending if a notify_version is explicitly set in the revocation payload.
I assume that if you are notifying then you always want to notify.
There was a problem hiding this comment.
I would think that is right. And presumably if notify_version is not set, it should default to something -- e.g. the latest version?
There was a problem hiding this comment.
I would think that is right. And presumably if
notify_versionis not set, it should default to something -- e.g. the latest version?
v1_0 is the default (it was the default before however the value wasn't getting passed through to the actual notification code so no notification was getting sent)
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Fixes: