Fixes for revocable credential issuance #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
andrewwhitehead
commented
Jan 8, 2022
andrewwhitehead
commented
- Fix RevocationError instantiations
- Ensure transaction is not left open when IndyIssuerRevocationRegistryFullError exception is raised
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1591 +/- ##
=======================================
Coverage 95.74% 95.74%
=======================================
Files 528 528
Lines 32515 32515
=======================================
Hits 31133 31133
Misses 1382 1382 |
|
@dbluhm - can you please test this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.