Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to EmbarkStudios/cargo-deny-action@v2 #1830

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

tottoto
Copy link
Collaborator

@tottoto tottoto commented Aug 1, 2024

Allows workspace-duplicates which is introduced at cargo-deny 0.15, and BSD-2-Clause which is newly pulled in dependencies.

deny.toml Outdated
@@ -3,6 +3,7 @@ all-features = true

[bans]
multiple-versions = "deny"
workspace-duplicates = "allow"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cargo-deny started to detect the same crates are used in the workspace but they are not defined by using workspace inheritance from version 0.15. In tonic project, a lot of crates are detected.

@tottoto
Copy link
Collaborator Author

tottoto commented Aug 1, 2024

0.15 seems not to be released at cargo-deny-action.

@djc
Copy link
Collaborator

djc commented Aug 1, 2024

0.15 seems not to be released at cargo-deny-action.

Filed EmbarkStudios/cargo-deny-action#79.

@tottoto
Copy link
Collaborator Author

tottoto commented Aug 1, 2024

The license part is resolved at #1831.

@tottoto
Copy link
Collaborator Author

tottoto commented Aug 2, 2024

cargo-deny 0.16 is released and it is released at cargo-deny-action 2. In this version, the workspace dependencies are changed not to be checked as default.

https://github.com/EmbarkStudios/cargo-deny/releases/tag/0.16.0

@tottoto tottoto changed the title chore: Update cargo-deny config chore: Update to EmbarkStudios/cargo-deny-action@v2 Aug 2, 2024
@djc djc added this pull request to the merge queue Aug 2, 2024
Merged via the queue into hyperium:master with commit 90f8734 Aug 2, 2024
16 checks passed
@tottoto tottoto deleted the update-cargo-deny-config branch August 2, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants