Da login fix #83
Da login fix #83
Conversation
DaClient has a new constructor overload which includes the option of passing username and password. These are used to build System.Net.NetworkCredential which in turn makes the Opc.ConnectData for the Opc.Da.server
Pulled out the main bits of the connect method into a private function. This allows both the interface Connect and the obejct specific conenct to use the same logic for all except the one line which changes.
|
Not sure why appveyor says the build failed... I'm using this library as written right now. Looking to the appveyor build, it looks like the failed items are nothing that I have changed. This leads me to believe the current master fails as well. |
|
Hi Syphontwo, Thanks for the contribution! I understand why you would think that. However, the error is actually caused by a tool we use that enforces certain style guidelines. Please review our getting started guide to see how to properly build locally to match the way we compile on appveyor. |
|
Thanks for the info, I'm working on getting this all setup now. Sorry I missed that part of the documentation! Not sure exactly when I'll be able to get it rolled over, but hopefully it will be today or tomorrow. |
setting up the cs-boilerplate correctly this time.
hit commit before seelcting this file, my bad
…DALoginFix Merging back with master
|
There we go! Passing no problem. The key issue was no space between the end of the |
Removed the gitignore inside the h-opc folder because there is already one in the directory above it. Removed App.config from the test project because it is no longer part of the project and was causing the build to fail.
remove extra gitignore and fix test project
The changes in this branch enable users to put in a username and password as non-secure strings when connecting to DA servers. I originally forked in order to get the functionality added by the Opc.Da.Url DaClient constructor which is not present in the NuGet package, but ended up making this small change and thought it would be good to post.