Expose OpcDa server for extensibility purposes #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpcDa server should be exposed as a protected property at least, so that the end-user of the library could inherit and extend DaClient class for one's needs. For example, I need to get timestamp along with each value I read. But I cannot do so without rewriting Read() method or adding whole new method in DaClient as well as in IClient<Node> interface. With this solution, one can easily inherit from DaNode class and implement any kind of behaviour based on OPC Foundation OpcDa library's functionality.
|
Please don't use c# 6.0 unless you truly need it. I would like this library to be as backwards compatible as possible |
|
No problem. I have dropped C# 6.0 syntax. Also, maybe it's a good idea to make this property public, because I know for certain that currently some people use this library as a simple OPC foundation library wrapper, utilizing OpcDa server using Reflection. But this would also require an interface change, and then we'll be leaking OpcDa details to the consumer, the library will become "leaky wrapper", so I decided it's best to make it protected (for now) so that at least anyone could inherit and extend it. |
|
I'm down with extensibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpcDa server should be exposed as a protected property at least, so that
the end-user of the library could inherit and extend DaClient class for
one's needs.
For example, I need to get timestamp along with each value I read. But I
cannot do so without rewriting Read() method or adding whole new method in
DaClient as well as in IClient interface.
With this solution, one can easily inherit from DaNode class and implement
any kind of behaviour based on OPC Foundation OpcDa library's
functionality.