Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change smartcard speed configuration in BBIO mode to custom value #88

Merged
merged 2 commits into from
Dec 8, 2018
Merged

Change smartcard speed configuration in BBIO mode to custom value #88

merged 2 commits into from
Dec 8, 2018

Conversation

sylvainpelissier
Copy link
Contributor

No description provided.

Copy link
Collaborator

@Baldanos Baldanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution !

Please take a look at the comment and correct your PR so I can merge your changes.

status = bsp_smartcard_init(proto->dev_num, proto);

if(status != BSP_OK) {
cprint(con, "\x00", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should reset to default speed in case of error.
Add the following lines here

proto->config.smartcard.dev_speed = SMARTCARD_DEFAULT_SPEED;
bsp_smartcard_init(proto->dev_num, proto);

@sylvainpelissier
Copy link
Contributor Author

Done.

@Baldanos Baldanos merged commit 2709637 into hydrabus:master Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants