-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structural improvements for low-level NFC command. No new function. #8
Conversation
Implemented try/catch Use semihosting traces for low-level debugging
Structural improvements for low-level NFC command. No new function.
Warning this update does not build anymore with makefile: Please build it with both EmBlocks & makefile as the both are supported (official release is makefile). Please also cleanup Warnings like "hydranfc\low_level\hydranfc_cmd_transparent.c:84:2: warning: 'return' with a value, in function returning void [enabled by default]" before to do any push. Please before to do any push use "Format using AStyle" in EmBlocks with Linux Kernel rules on new files (it is not the case on hydranfc_low_microrl.c ...) |
Sorry for the mess. I thought you were reviewing the pull request before merging. Is there a way fo your to test the pull before merging ? |
Maybe the best is you create a branch (for big modifications WIP) on your own repository and then I could check locally if all is ok and you can pull that branch on the trunk. |
Ok, mais il y aura toujours le risque que les makefiles soient foireux si tu ne valides pas. Sent from my iPad Mini
|
D'expérience utiliser l'interface github pour accepter un patch n'est pas idéal, personnellement j'interprète un pull req. comme une simple invitation à faire un merge "à la main". => je prends la branche de l'autre développeur chez moi, je teste et je merge, localement. Mais faire un merge par un simple clic sur une interface web, non merci. |
Oui tout a fait, c'est aussi a moi de faire l'effort, j'ai trop l'habitude L'idéal c'est ausis d'en parler sur IRC channel #hydrabus sur freenode 2014-11-16 19:19 GMT+01:00 Philippe Teuwen [email protected]:
|
Cela ne me derange pas d'essayer de mettre a jour les makefiles et d'avoir une branche séparée, si cela permet d'améliorer les choses. C'est un beau projet, autant pas tout casser :-) C'est juste que le merge aveugle sur le 'main' me parait pas non plus ideal. A+ |
Ce n'est pas un problème pour les makefile il faut juste m'indiquer dans le 2014-11-17 16:24 GMT+01:00 rdollet [email protected]:
|
There is a critical error: the exception do multiple definition during link with native makefile build with GNU_ARM_4_7_2013q3 |
See Issue comment "Structural improvements for low-level NFC command. No new function. #8"
No description provided.