Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/hydrabus/commands.c: improve help output on some console commands #156

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

ia
Copy link
Contributor

@ia ia commented Jan 9, 2024

Hello. Just another tiny help - patch to close the related task.

The local build has been successfully tested. The log from my hydrabus:

> jtag
Device: JTAG1
GPIO resistor: pull-up
Frequency: 2000000Hz
Bit order: LSB first
jtag1> help brute
Bruteforce JTAG pins on x pins starting from PB0
   bypass         Performs a BYPASS scan on x pins (PB0 up to PB11)
   idcode         Performs an IDCODE scan on x pins (PB0 up to PB11)
jtag1> exit
> 2-wire
Device: twowire1
GPIO resistor: floating
Frequency: 1000000Hz
Bit order: MSB first
twowire1> help brute
Perform a SWD enumeration on x pins (PB0 up to PB11)
twowire1> exit
>

Is it ok? Or should the 2-wire help output be in the full accordance with wiki, i.e. "Perform a SWD enumeration on x pins (PB0 up to PB11) with x from 2 to 11"? Let me know.

@bvernoux
Copy link
Member

bvernoux commented Jan 9, 2024

Thanks a lot for an other great contribution
It is perfect like that as if we add "with x from 2 to 11" it will be a bit too long at end the purpose was mainly to clarify the brute force is done using PB0 up to PB11 then additional details can be found in Wiki (or even checking source code ...)

@bvernoux bvernoux merged commit 45391d2 into hydrabus:master Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Help on some Console commands
2 participants