Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/Makefile: make 'make clean' clean all produced files #155

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

ia
Copy link
Contributor

@ia ia commented Jan 7, 2024

TL; DR: make make clean clean all produced files.

Steps to reproduce:

  • run build: $ make
  • clean produced files: $ make clean

What should happen:

  • usually, it's a common practice when after make clean all produced files are deleted

What actually happens:

  • src/common/hydrafw_version.hdr kept as "leftover"

At first I was thinking about adding a separate clean target into Makefile but since internal variables of rules.mk from ChibiOS support "custom enhancements", just adding command rm -f src/common/hydrafw_version.hdr to special variable do the trick.

I did successfully test it myself on Ubuntu 18.04. But I did not test it on Windows/mingw unfortunately.

P.S. Happy New Year! :)

@bvernoux
Copy link
Member

bvernoux commented Jan 8, 2024

Thanks for your contribution

@bvernoux bvernoux merged commit 1eca07b into hydrabus:master Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants