Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/Makefile: add target to flash firmware for convenience #150

Merged
merged 5 commits into from
Nov 27, 2023

Conversation

ia
Copy link
Contributor

@ia ia commented Nov 26, 2023

Hello. Just decided to share this tiny improvement for the main Makefile: in the case of compile-flash-run cycle, now just putting the device into dfu mode & running make flash will do the rest automagically. Can't wait to hear any feedback about this patch.

@bvernoux
Copy link
Member

bvernoux commented Nov 27, 2023

Thanks for the contribution, it is simple and shall do not have any border effect (I have not tested it so far)
The only potential issue is it is specific to Linux (as Windows support will requires a dedicated special version of dfu-util with same syntax and which fully support STM32F405 Flash ...) and it does not support Windows (with ifeq ($(OS), Windows_NT) using Windows ST DfuSeCommand.exe see https://github.com/hydrabus/hydrafw/tree/master/utils/windows_dfu_util)

@Baldanos Could you check if you do not see any issue on Linux ?

@ia
Copy link
Contributor Author

ia commented Nov 27, 2023

Thanks for the contribution

Thank YOU and every other contributor for this incredibly amazing open hardware project with open source firmware! The honor is mine to contribute at least something back.

The only potential issue is it is specific to Linux (as Windows support will requires a dedicated special version of dfu-util with same syntax and which fully support STM32F405 Flash ...)

Oops... Yes, indeed! Although I have a couple of fully proprietary hardware devices with Windows-only management software myself but for anything else I usually use Linux so I even didn't notice that this Makefile is Win-compatible!

and it does not support Windows (with ifeq ($(OS), Windows_NT) using Windows ST DfuSeCommand.exe see https://github.com/hydrabus/hydrafw/tree/master/utils/windows_dfu_util)

This is very interesting input! I'm sorry that I just didn't care to check the documentation for other host platforms. I did check the links now so I think I know how this patch can be improved. Thanks for the tip. I will try to make an update for the patch in the few hours.

src/Makefile Show resolved Hide resolved
@bvernoux bvernoux added this to the 0.12 milestone Nov 27, 2023
@bvernoux bvernoux merged commit 18639e4 into hydrabus:master Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants