onewire: Implement scan for multiple devices
#139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The former `scan` command only worked with a single 1-wire device attached. However, the 1-wire bus is ment as a bus, so there might be several devices connected to the bus. In that case, there is a suggested bus scanning scheme (cf. https://www.maximintegrated.com/en/design/technical-documents/app-notes/1/187.html) that makes clever use of pull-down collisions that will occur in such a situation. This allows to scan for all devices by basically doing a tree search. (The algorithm avoids recursion by using a few house-keeping variables to keep search state while discovering all devices ROM addresses.)
|
Very nice contribution !! |
|
Could you apply astyle (with recent astyle like Astyle 3.1) on final code (using coding style) ? |
Baldanos
requested changes
Sep 27, 2022
bvernoux
requested changes
Sep 27, 2022
Just tried that: This didn't change the new/changed code, but some other unrelated code. (Except the front-indention of the crc constants, which I would keep as-is, as this aligns the |
The file was given to `astyle -t --style=linux --lineend=linux hydrabus_mode_onewire.c`. However, the crc constants array was left untouched to keep the commas aligned.
jbglaw
requested review from
bvernoux and
Baldanos
and removed request for
bvernoux
bvernoux
approved these changes
Sep 28, 2022
bvernoux
approved these changes
Sep 28, 2022
|
All good to me. Thanks for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former
scancommand only worked with a single 1-wire device attached. However, the 1-wire bus is ment as a bus, so there might be several devices connected to the bus. In that case, there is a suggested bus scanning scheme (cf. https://www.maximintegrated.com/en/design/technical-documents/app-notes/1/187.html) that makes clever use of pull-down collisions that will occur in such a situation. This allows to scan for all devices by basically doing a tree search. (The algorithm avoids recursion by using a few house-keeping variables to keep search state while discovering all devices ROM addresses.)