Add special bbio mode for hydranfc #120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baldanos
requested changes
May 23, 2020
src/hydranfc/hydranfc_bbio_reader.c
Outdated
| chnRead(con->sdu, &c, 1); | ||
|
|
||
| if (c == 0) { | ||
| cprint(con, "BBIO2", 5); |
There was a problem hiding this comment.
The BBIOx string is already handled in hydrabus_bbio.c, this can be removed.
src/hydranfc/hydranfc_bbio_reader.c
Outdated
|
|
||
| while (!hydrabus_ubtn()) { | ||
|
|
||
| get_cmd(con, &bbio_subcommand, &length, rx_data); |
There was a problem hiding this comment.
I might be wrong, but this approach looks too cumbersome. For instance it needs 6 bytes to use the RF_OFF where only one byte could be enough.
Have a look at the bbio_mode_smartcard() in hydrabus_bbio_smartcard.c for an example implementation requiring additional bytes only when needed.
src/hydranfc/hydranfc_bbio_reader.h
Outdated
| /* | ||
| * HydraBus/HydraNFC | ||
| * | ||
| * Copyright (C) 2018 Nicolas OBERLI |
There was a problem hiding this comment.
You might want to change this
src/hydranfc/hydranfc_bbio_reader.c
Outdated
Comment on lines
123
to
127
| cprint(con, (char *) &tag, 2); | ||
| cprint(con, (char *) &length, 4); | ||
| if (length > 0) { | ||
| cprint(con, (char *) data, length); | ||
| } |
There was a problem hiding this comment.
You should not send user-supplied data back, but only command status and/or data read from the protocol.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.