Add environment variables to toggle different blocks in Docker container, fix constant typo #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Looks good to me, thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #35.
This PR allows you to disable the 'Network', 'Looking Glass' and 'Speedtest' blocks through environment variables in the Docker container.
These have to be explicitly passed in order to disable these blocks, contrary to the custom block environment variable, which has to be explicitly passed to enable it. This is 1) to keep forward compatibility so these blocks won't suddenly be gone after someone updates their container without adding these environment variables and 2) most people would probably want to have these blocks enabled, so enabling them by default seems good.
EDIT: I've also added some robuster checking around the custom block constants, namely by only including the files if both the constants are defined and the passed files actually exist.