-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add associated_data to encrypt/decrypt transit endpoints #1108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this! Haven't reviewed fully yet.
Could you rebase to get the testing changes in #1105?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1108 +/- ##
=======================================
Coverage 87.66% 87.66%
=======================================
Files 66 66
Lines 3227 3227
=======================================
Hits 2829 2829
Misses 398 398
|
Done! |
@JordanStopford it looks like the Ci failed last time this ran. Could you rebase or merge changes from |
@briantist I've merged everything now so hopefully it all passes! |
looks like there's just a few lint issues ( |
@briantist I've fixed the linting errors now, sorry about that! |
This resolves #1107 raised by Google/tink
I didn't see any tests for any of the other params to encrypt_data/decrypt_data so haven't added any for the new param as it's just passed through to Vault