Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add associated_data to encrypt/decrypt transit endpoints #1108

Merged
merged 5 commits into from
Mar 20, 2024

Conversation

JordanStopford
Copy link
Contributor

@JordanStopford JordanStopford commented Nov 29, 2023

This resolves #1107 raised by Google/tink

I didn't see any tests for any of the other params to encrypt_data/decrypt_data so haven't added any for the new param as it's just passed through to Vault

@JordanStopford JordanStopford requested a review from a team as a code owner November 29, 2023 09:27
@briantist briantist added enhancement a new feature or addition secrets engines generally related to a Vault secrets engine transit Transit secrets engine labels Dec 2, 2023
@briantist briantist self-assigned this Dec 2, 2023
Copy link
Contributor

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this! Haven't reviewed fully yet.
Could you rebase to get the testing changes in #1105?

hvac/api/secrets_engines/transit.py Outdated Show resolved Hide resolved
hvac/api/secrets_engines/transit.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.66%. Comparing base (b61d05d) to head (296e86d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1108   +/-   ##
=======================================
  Coverage   87.66%   87.66%           
=======================================
  Files          66       66           
  Lines        3227     3227           
=======================================
  Hits         2829     2829           
  Misses        398      398           
Files Coverage Δ
hvac/api/secrets_engines/transit.py 88.74% <ø> (ø)

@JordanStopford
Copy link
Contributor Author

Done!

@briantist
Copy link
Contributor

@JordanStopford it looks like the Ci failed last time this ran. Could you rebase or merge changes from main since it's been a while? I can't see the logs anymore so I'm not certain what was failing, but let's see! We should be able to get this merged quickly once it passes.

@JordanStopford
Copy link
Contributor Author

@briantist I've merged everything now so hopefully it all passes!

@briantist
Copy link
Contributor

looks like there's just a few lint issues (flake8), could you get those fixed up? you can run the linters locally to help catch these things sooner, which helps reduce turnaround time

@JordanStopford
Copy link
Contributor Author

@briantist I've fixed the linting errors now, sorry about that!

@briantist briantist added this to the 2.2.0 milestone Mar 20, 2024
@briantist briantist merged commit 19ad4f5 into hvac:main Mar 20, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement a new feature or addition secrets engines generally related to a Vault secrets engine transit Transit secrets engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for "associated_data" parameter in transit.encrypt_data and transit.decrypt_data.
2 participants