Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client.write method breaking changes 2.0.0 #1089

Merged
merged 10 commits into from
Oct 15, 2023
Merged

Client.write method breaking changes 2.0.0 #1089

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a66c6c7
add pytest-mock to dev deps
briantist Oct 15, 2023
b9c69fa
update client.write() and client.write_data() as announced
briantist Oct 15, 2023
7c6eb50
update test helpers to use write_data()
briantist Oct 15, 2023
fd31da4
update backend integration tests to use write_data
briantist Oct 15, 2023
1336e0d
add unit tests for new changes
briantist Oct 15, 2023
5bbcb00
use PendingDeprecationWarning
briantist Oct 15, 2023
252b3ef
more test coverage
briantist Oct 15, 2023
91c0611
update comment
briantist Oct 15, 2023
10a5fea
Update hvac/v1/__init__.py
briantist Oct 15, 2023
25c5e60
lint
briantist Oct 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update test helpers to use write_data()
  • Loading branch information
@briantist
briantist committed Oct 15, 2023
commit 7c6eb5093161f4b48d4327e4f4abef4129109202
28 changes: 17 additions & 11 deletions tests/utils/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,22 +253,28 @@ def configure_pki(

client.sys.enable_secrets_engine(backend_type="pki", path=mount_point)

client.write(
client.write_data(
path=f"{mount_point}/root/generate/internal",
common_name=common_name,
ttl="8760h",
data=dict(
common_name=common_name,
ttl="8760h",
),
)
client.write(
client.write_data(
path=f"{mount_point}/config/urls",
issuing_certificates="http:https://127.0.0.1:8200/v1/pki/ca",
crl_distribution_points="http:https://127.0.0.1:8200/v1/pki/crl",
data=dict(
issuing_certificates="http:https://127.0.0.1:8200/v1/pki/ca",
crl_distribution_points="http:https://127.0.0.1:8200/v1/pki/crl",
),
)
client.write(
client.write_data(
path=f"{mount_point}/roles/{role_name}",
allowed_domains=common_name,
allow_subdomains=True,
generate_lease=True,
max_ttl="72h",
data=dict(
allowed_domains=common_name,
allow_subdomains=True,
generate_lease=True,
max_ttl="72h",
),
)


Expand Down