Fix typo in safety_buffer argument in AWS auth
#1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1068 +/- ##
=======================================
Coverage 86.26% 86.27%
=======================================
Files 64 64
Lines 3101 3103 +2
=======================================
+ Hits 2675 2677 +2
Misses 426 426
|
kaypeter87
approved these changes
Sep 26, 2023
briantist
added
aws
briantist
approved these changes
Sep 26, 2023
|
Thanks for finding and fixing this @dosisod ! Thanks @kaypeter87 for reviewing! |
briantist
changed the title
safety_buffer argumentsafety_buffer argument in AWS auth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1057 (comment)
Deprecation announcement
The parameter
safety_bufferon the AWS auth method'stidy_blacklist_tagsandtidy_identity_whitelist_entriesmethods was misspelled assaftey_buffer.The parameter name has been corrected, and the correct name should be used going forward.
The old name still works for now, with a warning, but it will be removed in
v3.0.0.