Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rekey tests fail against Vault 0.5.x #40

Closed
ianunruh opened this issue Feb 11, 2016 · 1 comment
Closed

Rekey tests fail against Vault 0.5.x #40

ianunruh opened this issue Feb 11, 2016 · 1 comment
Labels
bug

Comments

@ianunruh
Copy link
Member

Due to the new requirement to provide nonce to rekey operations, the integration tests for HVAC fail against Vault 0.5.x. There should be a check around rekey operations for whether or not the nonce should be handled.
@ianunruh ianunruh added the bug label Feb 11, 2016
@ianunruh ianunruh changed the title Tests fail against Vault 0.5.x Rekey tests fail against Vault 0.5.x Feb 11, 2016
cburroughs added a commit to cburroughs/hvac that referenced this issue Mar 16, 2016
@cburroughs
fix rekey tests for vault 0.5.x
68c4be3 
To quote from the 0.5.x docs 'The rekey nonce operation must be
provided with each call.'.  This requires start_rekey to return
something other than None, which I believe is an innocuous api change.

fixes hvac#40
@cburroughs cburroughs mentioned this issue Mar 16, 2016
Closed
@ianunruh
Copy link
Member Author

Fixed in 19f55ec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ianunruh