-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an exception type for HTTP status code 412
#1093
Labels
Milestone
Comments
mweigel
added a commit
to mweigel/hvac
that referenced
this issue
Apr 4, 2024
* Fix hvac#1093 by adding PreconditionFailed exception for status code 412 * Add UnsupportedOperation exception for status code 405
mweigel
added a commit
to mweigel/hvac
that referenced
this issue
Apr 5, 2024
* Prepare for hvac#1093 by adding PreconditionFailed exception for status code 412 * Add UnsupportedOperation exception for status code 405
briantist
pushed a commit
that referenced
this issue
Apr 13, 2024
* Prepare for #1093 by adding PreconditionFailed exception for status code 412 * Add UnsupportedOperation exception for status code 405
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Right now there's no exception type for 412 status codes that get returned for eventual consistency failures, so we return
UnexpectedError
which is not very helpful on its own.hvac/hvac/exceptions.py
Line 21 in 8829ff2
Adding a dedicated type would be good for being able to catch this, or at least getting more useful feedback, though I'll stress that retries are better handled during the request: https://hvac.readthedocs.io/en/stable/advanced_usage.html#retrying-failed-requests
The text was updated successfully, but these errors were encountered: