Skip to content

Commit

Permalink
Fix CI Python 3.6 failing due to .ipynb (onnx#3367)
Browse files Browse the repository at this point in the history
* fix ipython version

Signed-off-by: Chun-Wei Chen <[email protected]>

* use 7.16.1 instead

Signed-off-by: Chun-Wei Chen <[email protected]>
  • Loading branch information
jcwchen committed Mar 29, 2021
1 parent d946f12 commit 25eba75
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion .azure-pipelines/Linux-CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,8 @@ jobs:
# onnx python api tests
# pytest 6.0 made deprecation warnings fail by default, pinning pytest to 5.4.3.
# TODO replace deprecated function with the suggested one. https://docs.pytest.org/en/stable/deprecations.html#id5
python -m pip install --quiet pytest==5.4.3 nbval
# TODO Remove fixed ipython 7.16.1 once ONNX remove Python 3.6
python -m pip install --quiet pytest==5.4.3 nbval ipython==7.16.1
pytest
if [ $? -ne 0 ]; then
Expand Down
3 changes: 2 additions & 1 deletion .azure-pipelines/MacOS-CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ jobs:
# onnx python api tests
# pytest 6.0 made deprecation warnings fail by default, pinning pytest to 5.4.3.
# TODO replace deprecated function with the suggested one. https://docs.pytest.org/en/stable/deprecations.html#id5
pip install --quiet pytest==5.4.3 nbval
# TODO Remove fixed ipython 7.16.1 once ONNX has removed Python 3.6
pip install --quiet pytest==5.4.3 nbval ipython==7.16.1
pytest
if [ $? -ne 0 ]; then
Expand Down
3 changes: 2 additions & 1 deletion .azure-pipelines/Windows-CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ jobs:
python -m pip install --upgrade pip
# pytest 6.0 made deprecation warnings fail by default, pinning pytest to 5.4.3.
# TODO replace deprecated function with the suggested one. https://docs.pytest.org/en/stable/deprecations.html#id5
python -m pip install --quiet pytest==5.4.3 nbval numpy
# TODO Remove fixed ipython 7.16.1 once ONNX has removed Python 3.6
python -m pip install --quiet pytest==5.4.3 nbval numpy ipython==7.16.1
git submodule update --init --recursive
set ONNX_BUILD_TESTS=1
Expand Down

0 comments on commit 25eba75

Please sign in to comment.