Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions #82

Closed
wants to merge 1 commit into from
Closed

Conversation

lfrancke
Copy link
Contributor

All of this is optional, feel free to close this PR.

Currently Github actions complains that outdated Node versions are used which will be deprecated/removed at some point. This means we need to update the Github actions versions and at the same time I took the liberty of pinning the dependencies. If you don't like that I can also move to the old v4 style again.

And when trying to run npm install with the current set of dependencies I get this error:

npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: [email protected]
npm error Found: [email protected]
npm error node_modules/svelte
npm error   dev svelte@"^4.2.2" from the root project
npm error
npm error Could not resolve dependency:
npm error peer svelte@"^3.35.0" from [email protected]
npm error node_modules/svelte-motion
npm error   dev svelte-motion@"^0.11.4" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /home/lars/.npm/_logs/2024-06-18T08_56_58_646Z-eresolve-report.txt
npm error A complete log of this run can be found in: /home/lars/.npm/_logs/2024-06-18T08_56_58_646Z-debug-0.log

With the old mode-watcher dependency I get this ominous error:

npm error code EUNSUPPORTEDPROTOCOL
npm error Unsupported URL Type "link:": link:@testing-library/jest-dom/matchers

- Pins GitHub actions to a commit SHA (https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions)
- Updates GitHub actions to get rid of deprecation warnings due to an outdated Node version
Copy link

changeset-bot bot commented Jun 18, 2024

🦋 Changeset detected

Latest commit: 51dbb40

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
cmdk-sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cmdk-sv ❌ Failed (Inspect) Jun 18, 2024 8:58am

@lfrancke
Copy link
Contributor Author

I can't see details on why Vercel failed.
I did run npm run build and npm run test locally and it worked but there's a good possibility this broke something.

@AdrianGonz97
Copy link
Collaborator

Thank you for the PR! I've already upgraded the deps separately in #86 as I didn't notice this PR was already open 😅 sorry about that, but much appreciated!

@lfrancke lfrancke deleted the version-updates branch July 17, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants