Merge pull request #107 from humanmade/remove-nextrun-index

Remove nextrun index

inc/namespace.php

@@ -94,8 +94,7 @@ function create_tables() {
  PRIMARY KEY (`id`),
  KEY `status` (`status`),
  KEY `site` (`site`),
- KEY `hook` (`hook`),
- KEY `nextrun` (`nextrun`)
+ KEY `hook` (`hook`)
  ) ENGINE=InnoDB {$charset_collate};\n";
 
  // TODO: check return value

inc/upgrade/namespace.php

@@ -33,6 +33,10 @@ function upgrade_database() {
  upgrade_database_3();
  }
 
+ if ( $database_version < 4 ) {
+ upgrade_database_4();
+ }
+
  update_site_option( 'cavalcade_db_version', DATABASE_VERSION );
 
  Job::flush_query_cache();
@@ -78,8 +82,21 @@ function upgrade_database_3() {
 
  $query = "ALTER TABLE `{$wpdb->base_prefix}cavalcade_jobs`
  ADD INDEX `site` (`site`),
- ADD INDEX `hook` (`hook`),
- ADD INDEX `nextrun` (`nextrun`)";
+ ADD INDEX `hook` (`hook`)";
+
+ $wpdb->query( $query );
+}
+
+/**
+ * Upgrade Cavalcade database tables to version 4.
+ *
+ * Remove nextrun index as it negatively affects performance.
+ */
+function upgrade_database_4() {
+ global $wpdb;
+
+ $query = "ALTER TABLE `{$wpdb->base_prefix}cavalcade_jobs`
+ DROP INDEX `nextrun`";
 
  $wpdb->query( $query );
 }

plugin.php

@@ -12,7 +12,7 @@
 namespace HM\Cavalcade\Plugin;
 
 const DATE_FORMAT = 'Y-m-d H:i:s';
-const DATABASE_VERSION = 3;
+const DATABASE_VERSION = 4;
 
 require __DIR__ . '/inc/namespace.php';
 require __DIR__ . '/inc/class-job.php';