Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore autosave_breakpoints_file behavior #969

Merged
merged 6 commits into from
Jul 22, 2023
Merged

Restore autosave_breakpoints_file behavior #969

merged 6 commits into from
Jul 22, 2023

Conversation

hugsy
Copy link
Owner

@hugsy hugsy commented Jul 21, 2023

Description/Motivation/Screenshots

The behavior of the autosave file for breakpoints got broken in #839. This PR restores it.

Fixes #965

It also updates all 2022 references in the code to 2023

Against which architecture was this tested ?

"Tested" indicates that the PR works and the unit test (see docs/testing.md) run passes without issue.

  • x86-32
  • x86-64
  • ARM
  • AARCH64
  • MIPS
  • POWERPC
  • SPARC
  • RISC-V

Checklist

  • My PR was done against the dev branch, not main.
  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

@hugsy hugsy added this to the Release: next milestone Jul 21, 2023
@hugsy hugsy marked this pull request as ready for review July 21, 2023 20:49
Grazfather
Grazfather approved these changes Jul 22, 2023
View reviewed changes
gef.py Outdated Show resolved Hide resolved
@hugsy hugsy merged commit e529fbc into dev Jul 22, 2023
3 checks passed
@hugsy hugsy deleted the hugsy/issue965 branch July 22, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Grazfather Grazfather Grazfather approved these changes

@daniellimws daniellimws Awaiting requested review from daniellimws

@theguy147 theguy147 Awaiting requested review from theguy147

Assignees
No one assigned
Labels
bug regression
Projects
None yet
Milestone
2023.08
Development

Successfully merging this pull request may close these issues.

[Bug] gef.autosave_breakpoints_file was removed
2 participants
@hugsy @Grazfather