Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main will be the default branch for gef-extras and gef installation #870

Merged
merged 1 commit into from
Jul 5, 2022
Merged

main will be the default branch for gef-extras and gef installation #870

merged 1 commit into from
Jul 5, 2022

Conversation

therealdreg
Copy link
Collaborator

@therealdreg therealdreg commented Jul 4, 2022

Before this PR, gef-extras.sh installation script uses dev branch by default.

main will be the default branch for gef-extras and gef installation. Also, it should be reflected in documentation.

Also I updated doc because standard users (non-devs) should use --branch main and devs/early_adopters should use --branch dev

IMO this PR must be merged in main (2022.06 - Upset Constant) as hotfix because installation via gef-extras.sh ONLY installs dev branch and dont works correctly with gef main.

Against which architecture was this tested ?

"Tested" indicates that the PR works and the unit test (i.e. make test) run passes without issue.

  • x86-32
  • x86-64
  • ARM
  • AARCH64
  • MIPS
  • POWERPC
  • SPARC
  • RISC-V

Checklist

  • My PR was done against the dev branch, not main.
  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

@therealdreg therealdreg changed the title main will be the default branch for gef-extras and gef main will be the default branch for gef-extras and gef installation Jul 4, 2022
Copy link
Owner

@hugsy hugsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change, we can safely assume that install scripts will be for non-contributors so no problem to change to main. But not for contributors, we'll receive PR against main which is not desirable.

docs/install.md Outdated Show resolved Hide resolved
@therealdreg therealdreg requested a review from hugsy July 5, 2022 11:53
@hugsy hugsy merged commit 819917d into hugsy:dev Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants