Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cleanly close opened files #737

Merged
merged 1 commit into from
Sep 30, 2021
Merged

fix: cleanly close opened files #737

merged 1 commit into from
Sep 30, 2021

Conversation

theguy147
Copy link
Collaborator

fix: cleanly close opened files

Description/Motivation/Screenshots

I noticed that GEF didn't close some of the files it opens and this PR should remedy this.

How Has This Been Tested?

Architecture Yes/No Comments
x86-32 ✔️
x86-64 ✔️
ARM ✖️
AARCH64 ✖️
MIPS ✖️
POWERPC ✖️
SPARC ✖️
RISC-V ✖️
make test ✔️

Checklist

  • My PR was done against the dev branch, not master.
  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • My change adds tests as appropriate.
  • I have read and agree to the CONTRIBUTING document.

@theguy147 theguy147 added this to the Release: 2021.10 milestone Sep 30, 2021
@hugsy hugsy merged commit 970a6d3 into hugsy:dev Sep 30, 2021
Functional Review of GEF (#693) automation moved this from In Progress to Closed Sep 30, 2021
@theguy147 theguy147 deleted the files branch September 30, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Grazfather Grazfather Grazfather approved these changes

@hugsy hugsy hugsy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Functional Review of GEF (#693)
Closed
Milestone
Release: 2021.10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@theguy147 @Grazfather @hugsy