Allow empty context titles #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugsy
requested changes
Sep 28, 2021
hugsy
approved these changes
Sep 28, 2021
Grazfather
reviewed
Sep 29, 2021
…into empty_context_title
Grazfather
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow empty context titles
Description/Motivation/Screenshots
To allow a user to implement a custom context pane we need to give them a way to print no title. This includes removing the entire title line so nothing looks off. Currently, if you return
""from the user function, which is handled withcontext_title, then you get an empty title line. We should have support for both an empty title line and the absence of one. I purpose we allow the user to returnNoneand modify thecontext_titlefunction slightly.How Has This Been Tested?
make testChecklist
devbranch, notmaster.