Backport Elf / ElfInfoCommand updates #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grazfather
reviewed
Sep 16, 2021
theguy147
requested changes
Sep 16, 2021
theguy147
reviewed
Sep 16, 2021
theguy147
reviewed
Sep 16, 2021
hugsy
requested changes
Sep 18, 2021
2 tasks
|
Removed the memory parsing from |
|
Maybe we should offer this code back to the bata fork as a show of good will? If you made some improvements? |
|
It's only a backport from batas code (even without the ability of memory parsing). Wouldn't make sense for him to include this. Other than that, I think, it goes without saying, that bata can take any of the changes (his base is gef after all anyways). |
|
Yep, but I meant the parts that you changed based on the PR review. |
|
Thank you for your concern. I overlooked the notification email, but now I'm watching this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport Elf / ElfInfoCommand updates
Description/Motivation/Screenshots
This patch is a backport of the changes from bata24 for Elf parsing and
ElfInfoCommand.It will additionally parse Program and Section Header Tables and display them in
ElfInfoCommand.Also added
is_qemu,is_qemu_usermodeandis_qemu_systemfunctions.Apart from improving
ElfInfoCommandthese changes prepare further backports of qemu functionality (likeksymaddr-remote-apply, which will need Section Header Table parsing for adding symbols).How Has This Been Tested?
make testChecklist
devbranch, notmaster.Credits
Credits to @bata24