-
-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport Elf / ElfInfoCommand updates #717
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is huge! Everything looks good here from a style perspective, but I haven't checked the actual proper parsing. I will compare it to readelf
or similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love that PR, this is something long overdue finally about to be part of GEF.
Just a couple of minor things to update, then we're good to merge. Thanks @Kileak !
Removed the memory parsing from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Maybe we should offer this code back to the bata fork as a show of good will? If you made some improvements? |
It's only a backport from batas code (even without the ability of memory parsing). Wouldn't make sense for him to include this. Other than that, I think, it goes without saying, that bata can take any of the changes (his base is gef after all anyways). |
Yep, but I meant the parts that you changed based on the PR review. |
Thank you for your concern. I overlooked the notification email, but now I'm watching this PR :) |
Backport Elf / ElfInfoCommand updates
Description/Motivation/Screenshots
This patch is a backport of the changes from bata24 for Elf parsing and
ElfInfoCommand
.It will additionally parse Program and Section Header Tables and display them in
ElfInfoCommand
.Also added
is_qemu
,is_qemu_usermode
andis_qemu_system
functions.Apart from improving
ElfInfoCommand
these changes prepare further backports of qemu functionality (likeksymaddr-remote-apply
, which will need Section Header Table parsing for adding symbols).How Has This Been Tested?
make test
Checklist
dev
branch, notmaster
.Credits
Credits to @bata24