Fix heap chunks cmd for multiple heaps per arena #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Grazfather
reviewed
Sep 16, 2021
Grazfather
reviewed
Sep 16, 2021
Grazfather
reviewed
Sep 16, 2021
hugsy
requested changes
Sep 18, 2021
4 tasks
Grazfather
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix heap chunks cmd for multiple heaps per arena
Description/Motivation/Screenshots
see #706, #709 and #711
This PR fixes the
heap chunkscommand for arenas with multiple heaps as described by @irontigran. The tests in #711 do work with this PR after fixing an error in it (when thebeforecmds are executed the heap has not been initialized yet).There are quite some chunks here so I added a screenshot of the beginning and the end of the command output:
How Has This Been Tested?
make testChecklist
devbranch, notmaster.