Fix gef-remote: retrieve pid of inferior process after having connected to target
#686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grazfather
reviewed
Jul 28, 2021
Grazfather
reviewed
Jul 28, 2021
|
I updated the PR to also take care of the findings in #693 for |
Grazfather
requested changes
Jul 31, 2021
Co-authored-by: Grazfather <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
gef-remote: retrieve pid of inferior process after having connected to targetDescription/Motivation/Screenshots
see #685
I still have to add better tests to
gef-remoteso this won't happen again but I wanted to open the PR already.How Has This Been Tested?
make testgef-remoteChecklist
devbranch, notmaster.