Fixed: memory watch uses new argparse syntax of hexdump cmd
#684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grazfather
reviewed
Jul 28, 2021
| @@ -247,6 +247,36 @@ def test_cmd_hexdump(self): | |||
| self.assertNoException(res) | |||
| return | |||
|
|
|||
| def test_cmd_memory_watch(self): | |||
There was a problem hiding this comment.
Would be nice if you wrote something to memory and then ensured that it showed up in the context.
There was a problem hiding this comment.
agreed. i will put it on my todo list ;)
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed:
memory watchuses new argparse syntax ofhexdumpcmdDescription/Motivation/Screenshots
see #681
memory watchnow uses the new argparse syntax ofhexdump. Also fixed relatedhexdumpusage instructions and documentation and added test to check for exceptions with thememorycommands.How Has This Been Tested?
make testsmake testand notmake tests, the template should be fixedChecklist
devbranch, notmaster.