Add git blob hash to version cmd
#683
Conversation
gef.py
Outdated
| @@ -4323,7 +4323,9 @@ def do_invoke(self, argv): | |||
| extra = "dirty" if len(subprocess.check_output('git ls-files -m', cwd=gef_dir, shell=True).decode("utf8").strip()) else "clean" | |||
There was a problem hiding this comment.
nit: Can you fix this line and previous to use double quotes? I believe in fixing nearby lines :)
| gef_print("GEF: (Standalone)") | ||
| gef_print("Blob Hash({}): {}".format(gef_fpath, gef_blob_hash)) |
There was a problem hiding this comment.
Maybe add to our issue template how to use this?
There was a problem hiding this comment.
Usage hasn't changed in my opinion. The Blob Hash is only printed in standalone mode and should be included when somebody opens an issue.
Or do you mean a little documentation on how the commit can be found using this blob hash from a developers point of view?
There was a problem hiding this comment.
Yes, I mean even a comment for the issue writer to maybe find the commit using this.
It's not really on them, but I am afraid that I myself will forget how to use this information. Maybe a blurb somewhere on a debugging doc, even.
Or maybe I should just remember how. 👀
There was a problem hiding this comment.
ok, i'll just add the version command to the documentation then
Grazfather
changed the title
version cmd
|
Looks great. Thanks a lot. |
|
oh, no! I made a "typo" in the documentation. I created PR #688 for it 😆 |
Add git blob hash to
versioncommandDescription/Motivation/Screenshots
see #682
gef.pyinside git dirstandalone
Checklist
devbranch, notmaster.