Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix python executable version in unicorn-emulate #678

Merged
merged 3 commits into from
Jul 23, 2021
Merged

Conversation

theguy147
Copy link
Collaborator

@theguy147 theguy147 commented Jul 22, 2021

fix python executable version in unicorn-emulate

Description/Motivation/Screenshots

Changes which("python") to which("python3") in the UnicornEmulateCommand.

This is required on some Distros to work correctly.

How Has This Been Tested?

Architecture Yes/No Comments
x86-32 ✖️
x86-64 ✔️ quick manual testing
ARM ✖️
AARCH64 ✖️
MIPS ✖️
POWERPC ✖️
SPARC ✖️
RISC-V ✖️
make tests ✔️ note: it is actually make test and not make tests

Checklist

  • My PR was done against the dev branch, not master.
  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required. (not required!)
  • My change adds tests as appropriate. (not needed)
  • I have read and agree to the CONTRIBUTING document.

EDIT:
referencing #677

@theguy147
Copy link
Collaborator Author

Seeing as python2 is anyway no longer supported since gef release 2020.03 I would also suggest to remove the pip2 installation instructions for the optional dependencies in the documentation (in docs/index.md).

I will add this change to this PR

@Grazfather
Copy link
Collaborator

LGTM.

Need to test it out.

@hugsy hugsy linked an issue Jul 23, 2021 that may be closed by this pull request
4 tasks
@hugsy hugsy added this to the Release 2021.10 milestone Jul 23, 2021
@hugsy hugsy merged commit c8dca47 into hugsy:dev Jul 23, 2021
@theguy147 theguy147 deleted the py3 branch July 31, 2021 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnicornEmulateCommand: "python" should be "python3"
3 participants