Fix address underflow on disassemble (Fixed-length ABI) #652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix context disassemble near 0x0
Description/Motivation/Screenshots
Firmware execution may start at address
0x0
. Disassembling instruction before addresses near0x0
leads to an address underflow and therefore angdb.MemoryError
exception duringcontext
.NOTE: An unmapped page may still be reached with the unchecked
addr - n * instruction_length
location calculation, so maybe removing the special case for fixed-sized ABI's may be the better solution.unfixed:
![image](https://user-images.githubusercontent.com/1280142/119148422-c3314900-ba4c-11eb-815a-ff38c91c3e56.png)
![image](https://user-images.githubusercontent.com/1280142/119148539-dd6b2700-ba4c-11eb-90ba-6c9437719d8e.png)
fixed:
How Has This Been Tested?
make tests
Checklist
dev
branch, notmaster
.