Fix address underflow on disassemble (Fixed-length ABI) #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, I don't do too much firmware debugging. Thanks for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix context disassemble near 0x0
Description/Motivation/Screenshots
Firmware execution may start at address
0x0. Disassembling instruction before addresses near0x0leads to an address underflow and therefore angdb.MemoryErrorexception duringcontext.NOTE: An unmapped page may still be reached with the unchecked
addr - n * instruction_lengthlocation calculation, so maybe removing the special case for fixed-sized ABI's may be the better solution.unfixed:
fixed:
How Has This Been Tested?
make testsChecklist
devbranch, notmaster.