Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gef-extras directory location #635

Merged
merged 8 commits into from
Apr 8, 2021
Merged

Fix gef-extras directory location #635

merged 8 commits into from
Apr 8, 2021

Conversation

hoefler02
Copy link
Contributor

@hoefler02 hoefler02 commented Apr 7, 2021

Better location for gef-extras

Description/Motivation/Screenshots

Moves the ~/gef-extras folder to ~/.config/gef-extras if it exists, or to ~/.gef-extras otherwise. This will help de-clutter the home folder. The gef installer already does this but the gef-extras installer does not.

How Has This Been Tested?

I ran several tests with different $HOME values to verify that the installer still works.

Checklist

  • My PR was done against the dev branch, not master.
  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • My change adds tests as appropriate.
  • I have read and agree to the CONTRIBUTING document.

@hoefler02 hoefler02 changed the title Fixed gef-extras directory location Fix gef-extras directory location Apr 7, 2021
@Grazfather
Copy link
Collaborator

This looks fine to me. Can you change the script to not confusingly (imo) set or not set DIR and name in the if else chain? don't get clever, just fully set the base path in that chain and use a single var in all the invocations

scripts/gef-extras.sh Outdated Show resolved Hide resolved
scripts/gef-extras.sh Outdated Show resolved Hide resolved
scripts/gef-extras.sh Outdated Show resolved Hide resolved
scripts/gef-extras.sh Outdated Show resolved Hide resolved
scripts/gef-extras.sh Outdated Show resolved Hide resolved
scripts/gef-extras.sh Outdated Show resolved Hide resolved
Michael Hoefler and others added 6 commits April 7, 2021 11:09
@hoefler02
Copy link
Contributor Author

Yes! Thanks for the suggestion! Not sure why I didn't it that way in the first place 😊

@Grazfather
Copy link
Collaborator

You forgot to remove $NAME usage. Please make sure to re-test

@hoefler02
Copy link
Contributor Author

My bad! Fixed and retested with different $HOME values and it is working now. Sorry about that

@Grazfather Grazfather merged commit f095a8b into hugsy:dev Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants