Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmd] Add a arch command for managing gef.arch #1114

Merged
merged 26 commits into from
Jun 2, 2024
Merged

[cmd] Add a arch command for managing gef.arch #1114

merged 26 commits into from
Jun 2, 2024

Conversation

ValekoZ
Copy link
Collaborator

@ValekoZ ValekoZ commented May 31, 2024 

Available subcommands:
- get  -> prints the current arch and the reason
- set  -> manually set the current arch (or auto-detect if no arg is provided)
- list -> list available architectures

Implements this: #1002

@github-actions GitHub Actions
Copy link

🤖 Coverage update for 64e251d 🔴

Old New
Commit 757f5bb 64e251d
Score 71.5302% 71.4923% (-0.0379)

@github-actions GitHub Actions
Copy link

🤖 Coverage update for bbcf528 🔴

Old New
Commit 757f5bb bbcf528
Score 71.5302% 71.4923% (-0.0379)

@github-actions GitHub Actions
Copy link

🤖 Coverage update for e74124e 🔴

Old New
Commit 757f5bb e74124e
Score 71.5302% 71.4923% (-0.0379)

@github-actions GitHub Actions
Copy link

🤖 Coverage update for 0fa4aee 🔴

Old New
Commit 757f5bb 0fa4aee
Score 71.5302% 71.4923% (-0.0379)

@github-actions GitHub Actions
Copy link

🤖 Coverage update for ab014b3 🔴

Old New
Commit 757f5bb ab014b3
Score 71.5302% 71.4923% (-0.0379)

@github-actions GitHub Actions
Copy link

🤖 Coverage update for 43e95dc 🔴

Old New
Commit 757f5bb 43e95dc
Score 71.5302% 71.4923% (-0.0379)

Grazfather
Grazfather reviewed Jun 1, 2024
View reviewed changes
gef.py Outdated Show resolved Hide resolved
gef.py Outdated Show resolved Hide resolved
gef.py Outdated Show resolved Hide resolved
gef.py Outdated Show resolved Hide resolved
gef.py Outdated Show resolved Hide resolved
gef.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 1, 2024

🤖 Coverage update for 1194c4c 🔴

Old New
Commit 757f5bb 1194c4c
Score 71.5302% 71.5112% (-0.019)

hugsy
hugsy requested changes Jun 1, 2024
View reviewed changes
Copy link
Owner

@hugsy hugsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good except that it's missing tests

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

🤖 Coverage update for 7681e0f 🟢

Old New
Commit 757f5bb 7681e0f
Score 71.5991% 71.5991% (0)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

🤖 Coverage update for c2e00be 🟢

Old New
Commit 757f5bb c2e00be
Score 71.5991% 71.5991% (0)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

🤖 Coverage update for 9b699f4 🟢

Old New
Commit 757f5bb 9b699f4
Score 71.5991% 71.5991% (0)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

🤖 Coverage update for f07434b 🟢

Old New
Commit 757f5bb f07434b
Score 71.5991% 71.5991% (0)

hugsy
hugsy requested changes Jun 2, 2024
View reviewed changes
Copy link
Owner

@hugsy hugsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor stuff to tweak and we're good

docs/commands/arch.md Outdated Show resolved Hide resolved
tests/commands/arch.py Outdated Show resolved Hide resolved
tests/commands/arch.py Show resolved Hide resolved
tests/commands/arch.py Outdated Show resolved Hide resolved
tests/commands/arch.py Outdated Show resolved Hide resolved
gef.py Outdated Show resolved Hide resolved
docs/commands/arch.md Outdated Show resolved Hide resolved
gef.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

🤖 Coverage update for 43f38e7 🟢

Old New
Commit 85008e2 43f38e7
Score 71.5991% 71.5991% (0)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

🤖 Coverage update for 928f51a 🟢

Old New
Commit 85008e2 928f51a
Score 71.5991% 71.5991% (0)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

🤖 Coverage update for 08578f8 🟢

Old New
Commit 85008e2 08578f8
Score 71.5991% 71.5991% (0)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

🤖 Coverage update for 32ef59f 🟢

Old New
Commit 85008e2 32ef59f
Score 71.5991% 71.5991% (0)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

🤖 Coverage update for 797da24 🟢

Old New
Commit 85008e2 797da24
Score 71.5991% 71.5991% (0)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

🤖 Coverage update for 46f44f4 🟢

Old New
Commit 85008e2 46f44f4
Score 71.5991% 71.637% (0.0379)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

🤖 Coverage update for b16c8fd 🟢

Old New
Commit 85008e2 b16c8fd
Score 71.5991% 71.5991% (0)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

🤖 Coverage update for cca5965 🟢

Old New
Commit 85008e2 cca5965
Score 71.5991% 71.5991% (0)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

🤖 Coverage update for f7269e0 🟢

Old New
Commit 85008e2 f7269e0
Score 71.5991% 71.5991% (0)

Grazfather
Grazfather reviewed Jun 2, 2024
View reviewed changes
docs/commands/arch.md Outdated Show resolved Hide resolved
docs/commands/arch.md Outdated Show resolved Hide resolved
gef.py Outdated Show resolved Hide resolved
gef.py Outdated Show resolved Hide resolved
gef.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

🤖 Coverage update for bef498b 🟢

Old New
Commit 85008e2 bef498b
Score 71.5991% 71.5991% (0)

Grazfather
Grazfather reviewed Jun 2, 2024
View reviewed changes
tests/commands/arch.py Outdated Show resolved Hide resolved
tests/commands/arch.py Outdated Show resolved Hide resolved
tests/commands/arch.py Outdated Show resolved Hide resolved
tests/commands/arch.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

🤖 Coverage update for 54a5a32 🟢

Old New
Commit 85008e2 54a5a32
Score 71.5991% 71.5991% (0)

hugsy
hugsy reviewed Jun 2, 2024
View reviewed changes
gef.py Show resolved Hide resolved
@hugsy hugsy linked an issue Jun 2, 2024 that may be closed by this pull request
Make reset_architecture accessible via command #1002
Closed
@hugsy hugsy added this to the 2024.06 milestone Jun 2, 2024
@hugsy hugsy merged commit cfda901 into hugsy:main Jun 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Grazfather Grazfather Grazfather left review comments

@hugsy hugsy hugsy approved these changes

Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
2024.06
Development

Successfully merging this pull request may close these issues.

Make reset_architecture accessible via command
3 participants
@ValekoZ @Grazfather @hugsy