Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pyenv related code (closes #1078) #1084

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

mattzque
Copy link
Contributor

@mattzque mattzque commented Apr 13, 2024

Description

Removes pyenv related functionality from gef.py.

See discussion at #1078

Checklist

  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

@mattzque mattzque mentioned this pull request Apr 13, 2024
9 tasks
Copy link

🤖 Coverage update for 2414e58 🟢

Old New
Commit 429a0e5 2414e58
Score 71.5407% 71.5407% (0)

@hugsy hugsy added this to the 2024.05 milestone Apr 13, 2024
@hugsy hugsy linked an issue Apr 13, 2024 that may be closed by this pull request
9 tasks
Copy link
Owner

@hugsy hugsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great.

Can I ask you to add a note in the docs like in this file saying pyenv support is dropped after 2024.05 ?

So we don't have future PRs for adding pyenv stuff.

@mattzque
Copy link
Contributor Author

That's great.

Can I ask you to add a note in the docs like in this file saying pyenv support is dropped after 2024.05 ?

So we don't have future PRs for adding pyenv stuff.

Of course, I've added a note.

Copy link

🤖 Coverage update for 2064247 🟢

Old New
Commit 429a0e5 2064247
Score 71.5407% 71.5407% (0)

@hugsy
Copy link
Owner

hugsy commented Apr 14, 2024

Minor formatting issue to fix before merging

docs/deprecated.md:22:101 MD013/line-length Line length [Expected: 100; Actual: 215]

Note that you can use pre-commit locally to make sure you're compliant before pushing.

Copy link

🤖 Coverage update for fe7f7a4 🟢

Old New
Commit 429a0e5 fe7f7a4
Score 71.5407% 71.5407% (0)

@hugsy hugsy merged commit d211658 into hugsy:main Apr 15, 2024
6 checks passed
@hugsy hugsy mentioned this pull request May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] AssertionError
2 participants