Migrate tests to RPyC #1040
Merged
Migrate tests to RPyC #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ception when in debug mode
…fUnitTestGeneric`
Grazfather
reviewed
Jan 8, 2024
Co-authored-by: Grazfather <[email protected]>
Grazfather
approved these changes
Jan 9, 2024
…rate_tests_to_rpyc
12 tasks
hugsy
added a commit
to hugsy/gef-extras
that referenced
this pull request
Jan 10, 2024
## Description/Motivation/Screenshots This PR is the GEF-Extras counter-part of hugsy/gef#1040 Also since `kallsyms` was removed from GEF (in preparation for the kernel module), it was added here with its tests ## How Has This Been Tested ? "Tested" indicates that the PR works *and* the unit test (i.e. `make test`) run passes without issue. * [x] x86-32 * [x] x86-64 * [ ] ARM * [x] AARCH64 * [ ] MIPS * [ ] POWERPC * [ ] SPARC * [ ] RISC-V ## Checklist <!-- N.B.: Your patch won't be reviewed unless fulfilling the following base requirements: --> <!--- Put an `x` in all the boxes that are complete, or that don't apply --> * [x] My code follows the code style of this project. * [x] My change includes a change to the documentation, if required. * [x] If my change adds new code, [adequate tests](https://hugsy.github.io/gef/testing) have been added. * [x] I have read and agree to the [CONTRIBUTING](https://github.com/hugsy/gef/blob/main/.github/CONTRIBUTING.md) document. --------- Co-authored-by: Grazfather <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a major PR, but long overdue.
GEF can now use RPyC to completely control the tests which not only make them way faster, also allow to control directly from the
pytesttests themselvesgdbandgef(see examples). Tests are therefore smaller, less messy, and more accurate than when using the legacy functiongdb_run_cmd.The documentation in
docs/testing.mdhas been updated accordingly.This allowed to find a few missing things in gef.py itself, which were added but nothing major.
Note that currently the PR is not perfect as I did not re-write the tests: I've migrated most of the code to the new API to ensure coverage stays identical. This was done because the PR is already big enough as it is. More accurate tests can be added in following PRs.
Checklist