Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Debruijn pattern to use 4 byte period #658

Closed
Grazfather opened this issue Jun 11, 2021 · 2 comments · Fixed by #661
Closed

Switch Debruijn pattern to use 4 byte period #658

Grazfather opened this issue Jun 11, 2021 · 2 comments · Fixed by #661
Labels
enhancement new feature
Milestone
Release 2021.07

Comments

@Grazfather
Copy link
Collaborator

  1. Better compatibility with pwntools
  2. You can search with a smaller segment
  3. You still get a ton of data before 'repeats'
@hugsy hugsy added this to the 2021-07 Release milestone Jun 11, 2021
@hugsy
Copy link
Owner

hugsy commented Jun 11, 2021

This will be handled directly in dev-argparse: set the default to 4 bytes and add a command line option -n

@Grazfather
Copy link
Collaborator Author

Great. Let's close this ticket after that PR is merged and we test its compatibility with pwntools.

hugsy pushed a commit that referenced this issue Jun 11, 2021
New addition for #659 :
d6fd038 
- added `pattern` command
- changed the default period to 4 for better compat with `pwntools` (fixed #658)
- updated unit tests
@hugsy hugsy mentioned this issue Jun 12, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement new feature
Projects
None yet
Milestone
Release 2021.07
Development

Successfully merging a pull request may close this issue.

Proper command argument parsing hugsy/gef
2 participants
@Grazfather @hugsy