Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any Plans To Ship ARM Images? #33

Closed
vkhitrin opened this issue May 27, 2023 · 3 comments
Closed

Any Plans To Ship ARM Images? #33

vkhitrin opened this issue May 27, 2023 · 3 comments

Comments

@vkhitrin
Copy link

Hey,

Are you also planning to ship arm64 images? Right now, all images are built for the amd64 architecture.
This a nitpick, but it would be nice to have.

Manually building the images work, but I was curious if there are any limitations to building arm64 in CI (for example, I don't know the constraints of CI/CD minutes for this project).

podman run --rm -it quay.io/vkhitrin/hugo:reg-base
hugo v0.112.3 linux/arm64 BuildDate=unknown
GOOS="linux"
GOARCH="arm64"
GOVERSION="go1.20.4"
@razonyang
Copy link
Member

Hi, I don't know where should I to start, I want to know more about this before setting about implementing it, so that I can test and confirm whether the arm64 images work. It would be helpful if there are references/docs about this.

PR are also welcome.

I don't know the constraints of CI/CD minutes for this project.

As I know, it's unlimited for public repositories.

GitHub Actions usage is free for standard GitHub-hosted runners in public repositories, and for self-hosted runners. https://docs.github.com/en/billing/managing-billing-for-github-actions/about-billing-for-github-actions#about-billing-for-github-actions

@vkhitrin
Copy link
Author

Hi, @razonyang,

Hi, I don't know where should I to start, I want to know more about this before setting about implementing it, so that I can test and confirm whether the arm64 images work. It would be helpful if there are references/docs about this.

There is a guide provided by Docker: https://docs.docker.com/build/ci/github-actions/multi-platform/
It is part of their GitHub action: https://github.com/docker/build-push-action#customizing

PR are also welcome.

I will try to propose a PR for this.

I don't know the constraints of CI/CD minutes for this project.

As I know, it's unlimited for public repositories.

GitHub Actions usage is free for standard GitHub-hosted runners in public repositories, and for self-hosted runners. https://docs.github.com/en/billing/managing-billing-for-github-actions/about-billing-for-github-actions#about-billing-for-github-actions

You are right. Their public runners should be free for all.

@vkhitrin
Copy link
Author

vkhitrin commented Jun 5, 2023

@razonyang, sorry for the delay. I was not able to follow up in a timely manner 😢.

Thank you for shipping ARM images!

razonyang added a commit that referenced this issue Jun 6, 2023
Closed #33: add multi-architecture support, but the exts support amd64 only.
Fixed #34: override the build date, commit hash and vendor info.
Fixed #36: push images to multiple registries in same job.
Trigger the workflow every 10 mins.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants