Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark logos #903

Merged
merged 2 commits into from
Mar 10, 2024
Merged

Add dark logos #903

merged 2 commits into from
Mar 10, 2024

Conversation

BernatBC
Copy link
Contributor

@BernatBC BernatBC commented Mar 9, 2024

Issue

Closes #902

Description

The config for using this feature looks like this:

- name: Studies
  icon: fa-graduation-cap
  timeframe: August 2023 - December 2023
  institution:
    name: University
    url: "https://www.example.com"
    logo: /images/school.png
    darkLogo: /images/school-dark.png

Basically, we just added:

    darkLogo: /images/school-dark.png

Test Evidence

I've provided two images. logo has black letters, and darkLogo has white letters. You can see below what's the behavior depending on the images provided

image
image

I'll add it to the guides after you approve it.

Copy link

netlify bot commented Mar 9, 2024

Deploy Preview for toha-ci ready!

Name Link
🔨 Latest commit 17ca97a
🔍 Latest deploy log https://app.netlify.com/sites/toha-ci/deploys/65ed8410549888000873336b
😎 Deploy Preview https://deploy-preview-903--toha-ci.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@hossainemruz hossainemruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE!

@hossainemruz hossainemruz merged commit 36e3e4c into hugo-toha:main Mar 10, 2024
10 of 12 checks passed
@BernatBC BernatBC deleted the add-dark-logo branch March 22, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Show different pictures for dark theme
2 participants