Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links of posts, notes, and tags/%s directories #703

Merged
merged 1 commit into from
Nov 12, 2022

Conversation

hiroyaonoe
Copy link
Contributor

Issue

https://toha-guides.netlify.app/posts is going to be redirected to https://toha-guides.netlify.app/posts/ because posts is a directory. notes and tags/%s are also the same.
There are such redirect links on some pages. For performance, it's not preferred to redirect them.

Description

This PR correct posts, notes and tags/%s to posts/, notes/ and tags/%s/

Test Evidence

Their links are going to be redirected to the correct pages, so there is no change in their behavior.
For example, the Posts link at the navbar in https://toha-guides.netlify.app/ will change from https://toha-guides.netlify.app/posts into https://toha-guides.netlify.app/posts/, but Both destination pages will be the same.

Copy link
Member

@hossainemruz hossainemruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hiroyaonoe

@hossainemruz hossainemruz added enhancement New feature or request automerge labels Nov 12, 2022
@hossainemruz hossainemruz merged commit 996346b into hugo-toha:main Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants