Allow setting GIFS as author image #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Glad to be of help @hossainemruz ! |
|
I believe this PR broke your theme. The assignment syntax "=" is incorrect from what I can tell. I don't have time to make an issue, because I'm not actually using the theme, but wanted to give you a heads up. |
|
@talves I will take a look when I can. Thank you for letting me know |
|
Remember when short declaration operator and trying to change it’s value type you would typically get an error. I think there's something going on with that here in the code. It may have always been there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
fixes #392
fixes #209
Description
allow_gifs - don't apply image processing to svg or gif
Test Evidence
Add a gif as a author image, and make sure it displays as expected on home page as well as single posts or anywhere else the author image is used.