Allow footer configuration #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default is to have the footer enabled (to keep backwards compatibility). The diff looks much worse than it is, I just added a variable and an if clause, but then had to indent the rest of the file. Make footerEnabled an explicit variable. This should improve readability. Use default parameter for even more readability.
Just set `footer.contactMe.enable` in the config. Default is true, for backwards compatibility.
Enabling footers elements and the newsletter is now managed in the same place.
|
@Kaligule Thank you for the PR. I think footer should be just another section so that user can use custom template for it. |
|
@hossainemruz I don't think I can help there. Do I understand you correctly that you do not want to merge this PR but work on your own solution? (I this case I will have to point my site to my own fork until you succeded.) |
Signed-off-by: hossainemruz <[email protected]>
hossainemruz
approved these changes
May 1, 2021
There was a problem hiding this comment.
Thanks @Kaligule . I have made little adjustment. Now, user can provide a template for the footer.
|
Cool, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced some new configuration options. These are the default values:
Where should the documentation go?
Please note that I am technically a web developer, but not familiar with hugo in the slightest. I am very happy about constructive feedback.
Btw it might be easier to review the commits one by one because the indentation makes the diff look more crazy than it is.
Issue
#224
Doesn't solve that issue completly as it is about the footer and the navbar. The navbar was a bit over my head at this moment.
Description
Allows to disable/enable parts of the footer (or all of the footer).
Test Evidence
Footer disabled
Navigation disabled
Footer enabled, but all parts of it disabled
Copyright notice disabled