Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find first section for chevron navigation #26

Merged
merged 2 commits into from
Jul 2, 2020
Merged

Find first section for chevron navigation #26

merged 2 commits into from
Jul 2, 2020

Conversation

blueyetisoftware-jason
Copy link
Contributor

No description provided.

@blueyetisoftware-jason
Copy link
Contributor Author

I wasn't sure how to sort by weight and also filter for only enable=true. I tried something similar to this using where but wasn't able to get it to work.
https://discourse.gohugo.io/t/solved-sort-and-where-in-a-range-site-data/8225/2

hossainemruz
hossainemruz requested changes Jul 1, 2020
View reviewed changes
layouts/partials/home.html Outdated Show resolved Hide resolved
@hossainemruz
Copy link
Member

hossainemruz commented Jul 2, 2020 •
edited
Loading

@blueyetisoftware I have pushed a change. Previously, the disabled sections was not handled properly. For example, if About section is disabled using section.enable: false it will be still present in the sorted map. Hence, the chevron was pointing to the about section.

Now, I have filtered the disabled sections using where function.

@hossainemruz hossainemruz merged commit 8658773 into hugo-toha:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hossainemruz hossainemruz hossainemruz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blueyetisoftware-jason @hossainemruz