Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-12 Hide unused sections if they are not defined in yaml #13

Conversation

blueyetisoftware-jason
Copy link
Contributor

Fixes #12

@hossainemruz
Copy link
Member

Hi @blueyetisoftware ! Thank you for the PR.

I was planning to do the same. However, there is an issue in this approach. If some intermediate sections are turned off, two consecutive section may have same background color. I am planning to make the background color dynamic. I will update this PR with the necessary changes. This may take some time.

@blueyetisoftware-jason
Copy link
Contributor Author

I noticed the same thing. Dynamic color would perfect for this. Great theme so far.

@hossainemruz
Copy link
Member

Hi @blueyetisoftware this fix required more complex changes. So, I have opened a new PR #14. Now, the sections are dynamic and the user has complete control over the sections. You can close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unused sections leave behind a blank row in the layout
2 participants