Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disqus deprecation warning #166

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

deining
Copy link
Contributor

@deining deining commented Feb 29, 2024

What problem does this PR solve?

Currently, when running hugo preview for the example site, a deprecation warning is emitted:

hugo --logLevel info --themesDir ../.. | grep deprecated
INFO  deprecated: .Site.DisqusShortname was deprecated in Hugo v0.120.0 and will be removed in a future release. Use .Site.Config.Services.Disqus.Shortname instead.

This PR fixes the deprecation warnings concerning the disqus comment system.

PR Checklist

  • I have verified that the code works as described/as intended.
  • This change does not include any external library/resources.
  • This change does not include any unrelated scripts (e.g. bash and python scripts).
  • I have enabled maintainer edits for this PR.

This PR also corrects the documentation for disqus comment system and for use of google analytics.

Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for hugo-blog-awesome ready!

Name Link
🔨 Latest commit 57f80aa
🔍 Latest deploy log https://app.netlify.com/sites/hugo-blog-awesome/deploys/65e0f737cbc4a10008efeeac
😎 Deploy Preview https://deploy-preview-166--hugo-blog-awesome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Owner

@hugo-sid hugo-sid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you @deining for :

  • fixing the deprecation warnings regarding disqus
  • upgrading Hugo version used in Netlify
  • renaming config.toml to hugo.toml

I greatly appreciate your contribution.

@hugo-sid hugo-sid merged commit 9f9c93a into hugo-sid:main Mar 4, 2024
7 checks passed
hugo-sid pushed a commit to deining/hugo-blog-awesome that referenced this pull request Mar 4, 2024
* fix deprecation warnings regarding disqus
* upgrade Hugo version used in Netlify
* rename config.toml to hugo.toml
@deining deining deleted the deprecation-disqus branch March 4, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants