Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ability to enable toc on certain posts ignore global toc settings #143

Merged
merged 5 commits into from
Dec 3, 2023
Merged

feat: add ability to enable toc on certain posts ignore global toc settings #143

merged 5 commits into from
Dec 3, 2023

Conversation

kirill-zak
Copy link
Contributor

What problem does this PR solve?

Add ability to enable toc on certain posts ignore global ToC settings.

Is this PR adding a new feature?

Added higher priority for the post ToC parameter instead of the global ToC parameter.

Is this PR related to any issue or discussion?

No

PR Checklist

  • I have verified that the code works as described/as intended.
  • This change adds a social icon which has a permissive license to use it.
  • This change does not include any external library/resources.
  • This change does not include any unrelated scripts (e.g. bash and python scripts).
  • I have enabled maintainer edits for this PR.

@netlify Netlify
Copy link

netlify bot commented Nov 15, 2023 •
edited
Loading

✅ Deploy Preview for hugo-blog-awesome ready!

Name Link
🔨 Latest commit 63558f0
🔍 Latest deploy log https://app.netlify.com/sites/hugo-blog-awesome/deploys/65612022d77a75000966336b
😎 Deploy Preview https://deploy-preview-143--hugo-blog-awesome.netlify.app/posts/table-of-content
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kirill-zak kirill-zak force-pushed the feat/add-inversion-logic-for-toc branch from c355c74 to 5910cc0 Compare November 17, 2023 12:50
@github-actions github-actions bot added size/m and removed size/s labels Nov 17, 2023
@kirill-zak
Copy link
Contributor Author

Hi @hugo-sid! Can your review this PR?

Tai-ch0802
Tai-ch0802 approved these changes Nov 24, 2023
View reviewed changes
Copy link

@Tai-ch0802 Tai-ch0802 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

exampleSite/content/en/posts/table-of-content/index.md Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

hugo-sid
hugo-sid approved these changes Dec 3, 2023
View reviewed changes
Copy link
Owner

@hugo-sid hugo-sid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kirill-zak sorry for the delay.

Thank you for improving ToC setting for Hugo blog awesome.

@hugo-sid hugo-sid merged commit d2a95ac into hugo-sid:main Dec 3, 2023
8 checks passed
@hugo-sid hugo-sid mentioned this pull request Dec 3, 2023
Merged
@kirill-zak kirill-zak deleted the feat/add-inversion-logic-for-toc branch December 4, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tai-ch0802 Tai-ch0802 Tai-ch0802 approved these changes

@hugo-sid hugo-sid hugo-sid approved these changes

Assignees
No one assigned
Labels
size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kirill-zak @Tai-ch0802 @hugo-sid