Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilingual support #121

Closed
wants to merge 0 commits into from
Closed

Multilingual support #121

wants to merge 0 commits into from

Conversation

fmaida
Copy link
Contributor

@fmaida fmaida commented Sep 21, 2023

What problem does this PR solve?

The theme can now display links, buttons and messages in languages other than English. Instead of having to edit the theme by hand, simply create a .yaml file inside the i18n folder.

Is this PR adding a new feature?

In order to display the dates in international format, I had to edit line no. 9 in the layout/partials/postcard.html file and use the time.Format command (documented here: https://gohugo.io/functions/dateformat/ )

time.Format is supported by Hugo only from version 0.87.0 onwards, so I had to raise the minimum theme requirements from version 0.86.0 to 0.87.0

Is this PR related to any issue or discussion?

Yes, please see discussion #118

PR Checklist

  • I have verified that the code works as described/as intended.
  • This change adds a social icon which has a permissive license to use it.
  • This change does not include any external library/resources.
  • This change does not include any unrelated scripts (e.g. bash and python scripts).
  • I have enabled maintainer edits for this PR.

@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for hugo-blog-awesome ready!

Name Link
🔨 Latest commit ab16ba1
🔍 Latest deploy log https://app.netlify.com/sites/hugo-blog-awesome/deploys/651001da78e4430008d8762a
😎 Deploy Preview https://deploy-preview-121--hugo-blog-awesome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hugo-sid
Copy link
Owner

hugo-sid commented Sep 21, 2023

@fmaida, this PR looks great so far.

I believe the only remaining component is a language switcher in the form of a dropdown menu. Would it be possible for you to incorporate this feature?

Regarding the placement of this dropdown, I feel it can appear after the About | but before the theme toggle in the navbar. I am open to considering other ideas.

@fmaida
Copy link
Contributor Author

fmaida commented Sep 21, 2023

@hugo-sid I'll try to make an update between tomorrow and Sunday

@github-actions github-actions bot added the conflicts This PR has conflicts which must be resolved before it can be reviewed. label Sep 23, 2023
@github-actions
Copy link

This pull request has conflicts with the base branch, please resolve those so that we can review the pull request.

@sonarcloud
Copy link

sonarcloud bot commented Sep 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts This PR has conflicts which must be resolved before it can be reviewed. size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants