Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Artalk comment system #56

Closed
wants to merge 0 commits into from
Closed

add Artalk comment system #56

wants to merge 0 commits into from

Conversation

hiifong
Copy link
Collaborator

@hiifong hiifong commented Jan 30, 2022

现在我添加加了Artalk评论系统
我用vscode修改toml和html会把内容格式化但是不影响，不知道你们用的什么ide，插件，可否推荐一下。

@vercel
Copy link

vercel bot commented Jan 30, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @Lruihao on Vercel.

@Lruihao first needs to authorize it.

@vercel
Copy link

vercel bot commented Jan 30, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lruihao/fixit/HoCkESsnMtAwLfziGvEoYQF5iBBD
✅ Preview: https://fixit-git-fork-iuvhub-master-lruihao.vercel.app

@Lruihao
Copy link
Member

Lruihao commented Jan 30, 2022

我用vscode修改toml和html会把内容格式化但是不影响，不知道你们用的什么ide，插件，可否推荐一下。

我用的 vscode,ESlint,然后把自动排版关掉了

@Lruihao Lruihao self-requested a review January 30, 2022 10:35
@Lruihao Lruihao self-assigned this Jan 30, 2022
@Lruihao Lruihao added the enhancement New feature or request label Jan 30, 2022
@Lruihao Lruihao added this to In progress in Roadmap via automation Jan 30, 2022
@Lruihao Lruihao added this to the v0.2.13 milestone Jan 30, 2022
@Lruihao Lruihao linked an issue Jan 30, 2022 that may be closed by this pull request
[FEATURE] 添加Artalk评论系统 #54
Closed
Roadmap automation moved this from In progress to Review in progress Jan 30, 2022
Lruihao
Lruihao requested changes Jan 30, 2022
View reviewed changes
Copy link
Member

@Lruihao Lruihao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iuvhub 麻烦你把格式改一下，然后 force push 一次，不然之后不好维护

@hiifong
Copy link
Collaborator Author

hiifong commented Jan 30, 2022

我用vscode修改toml和html会把内容格式化但是不影响，不知道你们用的什么ide，插件，可否推荐一下。

我用的 vscode,ESlint,然后把自动排版关掉了

我用的better toml

@hiifong
Copy link
Collaborator Author

hiifong commented Jan 30, 2022

@iuvhub 麻烦你把格式改一下，然后 force push 一次，不然之后不好维护

标题改成[FEATURE] 添加Artalk评论系统 #54？

@Lruihao
Copy link
Member

Lruihao commented Jan 30, 2022

我用vscode修改toml和html会把内容格式化但是不影响，不知道你们用的什么ide，插件，可否推荐一下。

我用的 vscode,ESlint,然后把自动排版关掉了

我用的better toml

toml 的标准格式没有缩进，不太好阅读，我希望尽量保留之前 LoveIt 的代码风格

@hiifong
Copy link
Collaborator Author

hiifong commented Jan 30, 2022

我用vscode修改toml和html会把内容格式化但是不影响，不知道你们用的什么ide，插件，可否推荐一下。

我用的 vscode,ESlint,然后把自动排版关掉了

我用的better toml

toml 的标准格式没有缩进，不太好阅读，我希望尽量保留之前 LoveIt 的代码风格

那我试试包代码的格式化给关了

@Lruihao
Copy link
Member

Lruihao commented Jan 30, 2022

@iuvhub 麻烦你把格式改一下，然后 force push 一次，不然之后不好维护

标题改成[FEATURE] 添加Artalk评论系统 #54？

没，就是代码的格式，issue和PR的标题问题不大

@Lruihao Lruihao changed the base branch from master to feature-artalk January 30, 2022 10:45
@hiifong
Copy link
Collaborator Author

hiifong commented Jan 30, 2022

ESlint

这个插件怎么关自动格式化

@Lruihao
Copy link
Member

Lruihao commented Jan 30, 2022

ESlint

这个插件怎么关自动格式化

你可以暂时禁用，改完之后再打开。只有提交的PR不牵连到原来代码的格式就行。

@hiifong hiifong closed this Jan 30, 2022
Roadmap automation moved this from Review in progress to Done Jan 30, 2022
@Lruihao Lruihao added duplicate This issue or pull request already exists and removed enhancement New feature or request labels Jan 30, 2022
@Lruihao
Copy link
Member

Lruihao commented Jan 30, 2022

#57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lruihao Lruihao Lruihao requested changes

Assignees

@Lruihao Lruihao

Labels
duplicate This issue or pull request already exists
Projects
Roadmap of FixIt
Archived in project
Roadmap
  
Done
Milestone
v0.2.13
Development

Successfully merging this pull request may close these issues.

[FEATURE] 添加Artalk评论系统
2 participants
@hiifong @Lruihao