Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] 添加Artalk评论系统 #54

Closed
hiifong opened this issue Jan 28, 2022 · 20 comments · Fixed by #57
Closed

[FEATURE] 添加Artalk评论系统 #54

hiifong opened this issue Jan 28, 2022 · 20 comments · Fixed by #57
Assignees
@Lruihao @hiifong
Labels
enhancement New feature or request tested Processing completion test passed
Projects
Roadmap
Milestone
v0.2.13

Comments

@hiifong
Copy link
Collaborator

hiifong commented Jan 28, 2022

https://github.com/ArtalkJS/Artalk
这个评论系统后端自建
image
@hiifong hiifong added the enhancement New feature or request label Jan 28, 2022
@Lruihao Lruihao added this to the v0.2.13 milestone Jan 28, 2022
@Lruihao Lruihao added this to To do in Roadmap via automation Jan 28, 2022
@Lruihao Lruihao self-assigned this Jan 28, 2022
@Lruihao
Copy link
Member

Lruihao commented Jan 28, 2022

马上过年了，预计年后处理

@hiifong
Copy link
Collaborator Author

hiifong commented Jan 28, 2022

辛苦大佬了

@Lruihao Lruihao linked a pull request Jan 30, 2022 that will close this issue
add Artalk comment system #56
Closed
@hiifong hiifong mentioned this issue Jan 30, 2022
Closed
@Lruihao Lruihao linked a pull request Jan 30, 2022 that will close this issue
add Artalk comment system #57
Merged
Lruihao added a commit that referenced this issue Jan 30, 2022
@Lruihao
🎉 Feat: add Artalk comment support (#54)
160020b
Lruihao added a commit that referenced this issue Jan 30, 2022
@Lruihao
🎉 Feat: add Artalk comment support (#54)
cace855
@Lruihao
Copy link
Member

Lruihao commented Jan 30, 2022 •
edited
Loading

@iuvhub feature-artalk 分支 已合并你的PR，并做了优化，有空的话麻烦你测试一下，没问题我就合并到 v0.2.13-RC

@Lruihao Lruihao moved this from To do to In progress in Roadmap Jan 30, 2022
@Lruihao Lruihao moved this from In progress to Review in progress in Roadmap Jan 30, 2022
@Lruihao Lruihao moved this from Review in progress to In progress in Roadmap Jan 30, 2022
Lruihao added a commit that referenced this issue Jan 30, 2022
@Lruihao
🎉 Feat: add Artalk comment support (#54)
862d313
@Lruihao
Copy link
Member

Lruihao commented Jan 30, 2022

image

Lruihao added a commit that referenced this issue Jan 30, 2022
@Lruihao
✨ Perf: optimize Artalk config (#54)
7d62af6
@Lruihao
Copy link
Member

Lruihao commented Jan 30, 2022

image
已自动调整 暗黑主题

Lruihao added a commit that referenced this issue Jan 30, 2022
@Lruihao
🔧 Merge branch 'feature-artalk' into v0.2.13-RC (#54)
c676b0d
@Lruihao
Copy link
Member

Lruihao commented Jan 30, 2022 •
edited
Loading

🔧 Merge branch 'feature-artalk' into v0.2.13-RC, Thanks @iuvhub

@Lruihao Lruihao closed this as completed Jan 30, 2022
Roadmap automation moved this from In progress to Done Jan 30, 2022
@hiifong
Copy link
Collaborator Author

hiifong commented Jan 30, 2022

🔧 Merge branch 'feature-artalk' into v0.2.13-RC, Thanks @iuvhub

标题好像还是没有获取到image

@hiifong
Copy link
Collaborator Author

hiifong commented Jan 30, 2022

我当时通过.Title是可以直接获取的。

@Lruihao
Copy link
Member

Lruihao commented Jan 30, 2022

我当时通过.Title是可以直接获取的。

你在控制台输入 this.config.comment.artalk看看有没有包含 pageKey 和 pageTitle

没有的话，更新到 v0.2.13-RC 最新版，然后刷新浏览器缓存试试

@hiifong
Copy link
Collaborator Author

hiifong commented Jan 30, 2022

这个就是最新版本
image

@Lruihao Lruihao reopened this Jan 30, 2022
Roadmap automation moved this from Done to In progress Jan 30, 2022
@Lruihao
Copy link
Member

Lruihao commented Jan 30, 2022

这个就是最新版本

image

现在问题是什么？明天我仔细看看这两个参数的作用

@hiifong
Copy link
Collaborator Author

hiifong commented Jan 30, 2022

邮件里没有pageTitle和pageKey
image

@Lruihao
Copy link
Member

Lruihao commented Jan 31, 2022

@iuvhub 有空帮忙看看，现在可不可以

image

Lruihao added a commit that referenced this issue Jan 31, 2022
@Lruihao
🐛 Fix: Artalk comment pageKey & pageTitle not effective (#54)
c64ebb4
@Lruihao Lruihao added the testing Processing completed to be tested label Jan 31, 2022
@hiifong
Copy link
Collaborator Author

hiifong commented Jan 31, 2022

这是artalk的一个bug，当site的值为默认站点的话，才可以正常收到pageTitle，其他的就不行

@Lruihao
Copy link
Member

Lruihao commented Jan 31, 2022

这是artalk的一个bug，当site的值为默认站点的话，才可以正常收到pageTitle，其他的就不行

是 artalk 后端收不到吗，如果是 artalk 的bug 只能等他修复。

FixIt 目前设定是默认 pageKey 为页面链接，pageTitle 为页面标题。

@hiifong
Copy link
Collaborator Author

hiifong commented Jan 31, 2022

这是后端获取到的部分数据
image

@hiifong
Copy link
Collaborator Author

hiifong commented Jan 31, 2022

这是artalk的一个bug，当site的值为默认站点的话，才可以正常收到pageTitle，其他的就不行

是 artalk 后端收不到吗，如果是 artalk 的bug 只能等他修复。

FixIt 目前设定是默认 pageKey 为页面链接，pageTitle 为页面标题。

应该是bug吧，我给他提issue了

@hiifong
Copy link
Collaborator Author

hiifong commented Jan 31, 2022

那可以先把site的默认值设为“默认站点”，这样就可以正常获取到pageTitle了

@Lruihao
Copy link
Member

Lruihao commented Jan 31, 2022 •
edited
Loading

那可以先把site的默认值设为“默认站点”，这样就可以正常获取到pageTitle了

site 留空 artalk 应该会传默认值吧

@Lruihao
Copy link
Member

Lruihao commented Jan 31, 2022 •
edited
Loading

应该是你的后端配置问题，我用 artalk 官方的 API 测试,邮件内容都是正常的

[params.page.comment.artalk]
  server = "https://artalk.qwqaq.com/api/"
  site = "ArtalkDocs"
  placeholder = ""
  noComment = ""
  sendBtn = ""
  editorTravel = true
  flatMode = 'auto'
  maxNesting = 3

image

image

@Lruihao Lruihao closed this as completed Jan 31, 2022
Roadmap automation moved this from In progress to Done Jan 31, 2022
@Lruihao Lruihao added tested Processing completion test passed and removed testing Processing completed to be tested labels Jan 31, 2022
@hugo-fixit hugo-fixit locked as resolved and limited conversation to collaborators Mar 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Lruihao Lruihao

@hiifong hiifong

Labels
enhancement New feature or request tested Processing completion test passed
Projects
Roadmap of FixIt
Archived in project
Roadmap
  
Done
Milestone
v0.2.13
Development

Successfully merging a pull request may close this issue.

add Artalk comment system
add Artalk comment system
2 participants
@Lruihao @hiifong