Test fetcher: missing return on filtered tests; don't write empty files #33224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(see slack convo: https://huggingface.slack.com/archives/C014N4749J9/p1725033526299719) |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
thanks! If the test list is empty, we should not even have the job start! I think this was fixed on main by #33220
ArthurZucker
approved these changes
Aug 30, 2024
itazap
pushed a commit
to NielsRogge/transformers
that referenced
this pull request
Sep 20, 2024
…es (huggingface#33224) * missing return * skip files without contents * test 2 * dbg * dbg * how about this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See title :)
This PR addresses two problems:
missing return
The
filter_tests(tests, module=module)call always returnedNone, because it is missing areturn. ThisNonewould then cause the fetcher to fail: https://app.circleci.com/pipelines/github/huggingface/transformers/102546/workflows/5e358605-da6b-4c2f-886f-84c9e455a211/jobs/1365782With this return, the failing job above no longer happens, and CI runs as expected :) (see this PR)
writing empty files
The test fetcher can write empty files for a given job (e.g.
test_preparation/tests_torch_and_tf_test_list.txt). This caused a downstream error because:Uploading artifacts)curlstep (see here)As such, this PR changes our test fetcher to skip writing a test file if the file is empty 🤗 No file -> no job -> no problem